1
Vote

There is no setter on Dump.Skip

description

There is no public setter on Dump.Skip, so the example you provide cannot be used :
[Dump(Skip=ShouldDump.Skip)]
public string Unimportant { get; set; }

comments

VMelamed wrote May 24, 2016 at 10:43 PM

Yes, thought that [Dump(false)] is much simpler than [Dump(Skip=ShouldDump.Skip)]... I guess I haven't tried the sample program for some time. To avoid confusion, I should allow both forms and will make sure that the sample works..

By the way the current version is on GitHub: https://github.com/vmelamed/vm/tree/master/Aspects/Diagnostics.

killergege wrote May 25, 2016 at 8:54 AM

Ok thanks, I chose the second option because I think it's easier to read at a glance but I ended up using the first one. No big deal, it's just better to have the documentation matching the current release :).

About Github, I found your library through Nuget and followed the project information link, you might want to update that to the "real" current version, no ?

VMelamed wrote May 26, 2016 at 3:48 AM

I just made both forms available in the source code (sync-ed in GitHub). Also changed the URL-s the nuspec file. It needs some testing (see my comments on the other idea) and soon I'll release it on NuGet. Meanwhile, you are more than welcome to try it out from source code.

Thank you very much for the comments! I guess when only you use your own library, you use it in the way you think it should be used. But when others start using it they suggest even better ways.

Val